-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bf release #16
Bf release #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks but overall reads well. A few items from the internal release process were not ported to this page:
- the addition of external contributors
- the update of the Bio-Formats examples
- the testing instructions for the artifacts
I feel that the testing part is a bit out of place and late in the release process. The rest has been adjusted. Happy to discuss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes suggested, otherwise the big missing piece are the tetsing instructions
Co-authored-by: David Gault <[email protected]>
Co-authored-by: David Gault <[email protected]>
I feel that this should be done before the release process cf. my previous comment |
Testing section added @dgault with retractions steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the addition of the testing section this looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two inline comments for possible follow-up actions. Otherwise, this reads well to me and captures all essential aspects of the release process
--------------------- | ||
|
||
To test the artifacts published, | ||
- Test the `bio-formats-command-line-tools <https://docs.openmicroscopy.org/internal/testing_scenarios/GeneralRelease.html#bio-formats-command-line-tools>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As these hyperlinks require (UoD?) authentication, I suspect a follow-up action might be to extract these testing scenarios to a public page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is.
This is something that we need to extract. we faced the same issue during the Django upgrade testing
$ mvn versions:set -DnewVersion=x.y.z -DgenerateBackupPoms=false | ||
$ mvn versions:set-property -Dproperty=formats-gpl.version -DnewVersion=x.y.z -DgenerateBackupPoms=false | ||
|
||
Bump the ``version`` and ``formats-gpl`` in :file:`build.gradle`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note with ome/bio-formats-examples#128 the proposal is to only have formats-bsd
as a depedency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have to be adjusted accordingly when the example PR is merged
Add Bio-Formats release instruction